Skip to content

Conversation

@torredil
Copy link
Member

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

Update metadata labeler unit tests to be deterministic by removing instances of time.Sleep() and other anti-patterns in the testing code that make it brittle / prone to flakes. See testgrid: https://testgrid.k8s.io/provider-aws-ebs-csi-driver#ci-unit-test.

How was this change tested?

go test -race -v ./pkg/cloud/metadata -run "^Test(GetMetadata|PatchSingleNode|PatchNodes|VolumeIDIndexFunc|GetNonCSIManagedVolumes)$" -count=100 -timeout=10m

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign torredil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2025
@github-actions
Copy link

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/metadata/labels.go 57.8% 49.1% -8.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants