feat: Update sandbox status with phase #121
Open
+101
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-sandbox canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
barney-s
force-pushed
the
issue-119-fixes
branch
from
c175169 to
f1024c1
Compare
k8s-ci-robot
added
size/L
barney-s
force-pushed
the
issue-119-fixes
branch
from
f1024c1 to
7f541c2
Compare
Adds a 'Phase' field to the 'SandboxStatus' to provide a more explicit status representation of the sandbox. The phase can be one of 'Pending', 'Running', 'Paused', 'Terminating', or 'Failed'. This addresses issue kubernetes-sigs#119.
barney-s
force-pushed
the
issue-119-fixes
branch
from
7f541c2 to
84ed9ec
Compare
barney-s
force-pushed
the
issue-119-fixes
branch
from
84ed9ec to
cb934d6
Compare
k8s-ci-robot
added
size/XS
barney-s
force-pushed
the
issue-119-fixes
branch
from
cb934d6 to
5429888
Compare
k8s-ci-robot
added
size/L
barney-s
force-pushed
the
issue-119-fixes
branch
from
5429888 to
75760ac
Compare
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
barney-s
force-pushed
the
issue-119-fixes
branch
from
75760ac to
7b3914d
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
barney-s
force-pushed
the
issue-119-fixes
branch
3 times, most recently
from
50a76b7 to
b3dd8d6
Compare
k8s-ci-robot
added
size/M
barney-s
force-pushed
the
issue-119-fixes
branch
from
b3dd8d6 to
ddd4ea8
Compare
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
k8s-ci-robot
added
size/L
barney-s
force-pushed
the
issue-119-fixes
branch
from
ddd4ea8 to
84ed9ec
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
hzxuzhonghu
approved these changes
Nov 6, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barney-s, hzxuzhonghu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@justinsb can you approve, we want to use this explicit status |
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'Phase' field to the 'SandboxStatus' to provide a more explicit status representation of the sandbox.
The phase can be one of 'Pending', 'Running', 'Paused', 'Terminating', or 'Failed'.
This addresses issue #119.