-
Notifications
You must be signed in to change notification settings - Fork 405
Parse go version from release-tools #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
trivy.yaml should use the same go version as release tools, so it checks for CVEs with the same go as we use to build images. Add a step that parses the go version from prow.sh and stores it in .goversion file. Use the file in subsequent setup-go step.
|
trivy logs:
And it continues with 1.24.9 |
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a Bump actions/checkout from 5 to 6 294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs git-subtree-dir: release-tools git-subtree-split: 8d1258cce8062a7ff5de7e10b10f01bed3e9c677
to fix a CVE
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
trivy.yaml should use the same go version as release tools, so it checks for CVEs with the same go as we use to build images.
Add a step that parses the go version from prow.sh and stores it in .goversion file. Use the file in subsequent setup-go step.
In addition:
What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: