Skip to content

Conversation

@ttuellmann
Copy link
Contributor

This fixes three minor issues in the KubeOne tutorial "Creating a Kubernetes Cluster on Bare-Metal":

  • The number of control plane nodes should be odd rather than even
  • The manifest in step 3 used the taint node-role.kubernetes.io/master on the control plane nodes, which has been removed in all supported K8s releases.
  • I bumped the K8s release to 1.32.3 in the manifest

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2025
@kubermatic-bot
Copy link
Contributor

Hi @ttuellmann. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2025
@kubermatic-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubermatic-bot kubermatic-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2025
@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/test all

@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 4025f10d9b3b60c4592617112f029a9e8bfca84d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@kubermatic-bot kubermatic-bot merged commit de5c741 into kubermatic:main Aug 4, 2025
10 of 11 checks passed
@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

@ttuellmann thank you and sorry for the delay, we somehow lost this PR 🤷

@ttuellmann
Copy link
Contributor Author

@kron4eg No worries, thanks for getting it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants