-
Notifications
You must be signed in to change notification settings - Fork 118
Improving the creating-clusters-baremetal tutorial in KubeOne docs #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thorsten Tüllmann <[email protected]>
…k8s version Signed-off-by: Thorsten Tüllmann <[email protected]>
|
Hi @ttuellmann. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
/test all |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 4025f10d9b3b60c4592617112f029a9e8bfca84d |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ttuellmann thank you and sorry for the delay, we somehow lost this PR 🤷 |
|
@kron4eg No worries, thanks for getting it merged. |
This fixes three minor issues in the KubeOne tutorial "Creating a Kubernetes Cluster on Bare-Metal":
node-role.kubernetes.io/masteron the control plane nodes, which has been removed in all supported K8s releases.