feat: Upgrade Go to 1.24 - notebook-controller component. #721

[abdallahsamabd]

No description provided.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abdallahsamabd]

links
https://github.com/abdallahsamabd/notebooks/actions/runs/19413082564/job/55537283384
https://github.com/abdallahsamabd/notebooks/actions/runs/19413082562/job/55537283348
https://github.com/abdallahsamabd/notebooks/actions/runs/19413082561/job/55537283395
https://github.com/abdallahsamabd/notebooks/actions/runs/19413082555/job/55537283349

[abdallahsamabd]

[liavweiss]

Thank you, Abdalla
Validations and code are looking good
Please also change the version (Go) lines in the README.md file:

• https://github.com/abdallahsamabd/notebooks/blob/feat/721/components/notebook-controller/README.md#:~:text=need%20to%20use-,Go%201.17,-and%20up%20in
• https://github.com/abdallahsamabd/notebooks/blob/feat/721/components/notebook-controller/README.md#:~:text=go-,version%20v1.17%2B,-.

[abdallahsamabd]

/assign

[liavweiss]

close: #721
Thank you, Abdalla
/lgtm

[liavweiss]

Hey @abdallahsamabd , following my earlier review, I noticed one more thing that could be improved. It’s not mandatory, but it would make the code cleaner.

notebooks/components/notebook-controller/Dockerfile

Line 30 in 8c139d6

RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -mod=mod -o manager main.go

I checked our environment and the module cache is writable, so -mod=mod doesn’t add anything in Go 1.20+.
GO111MODULE=on is also deprecated and has no effect since modules are always enabled now.

We can remove these flags, though it’s not required for the PR approval.

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[abdallahsamabd]

done