Upgrade Kubernetes dependencies to v1.34 #742
Merged
+1,020
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzen-y
force-pushed
the
update-kube-version
branch
2 times, most recently
from
0f2b264 to
0625b55
Compare
tenzen-y
force-pushed
the
update-kube-version
branch
from
0625b55 to
2e2b372
Compare
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
update-kube-version
branch
from
2e2b372 to
7e445bf
Compare
tenzen-y
commented
Oct 30, 2025
| sigs.k8s.io/kind v0.30.0 | ||
| sigs.k8s.io/scheduler-plugins v0.33.5 | ||
| sigs.k8s.io/structured-merge-diff/v6 v6.3.0 | ||
| volcano.sh/apis v1.13.1-0.20251028070205-46d20c0699e7 // TODO: Once the stable volcano APIs compatible with K8s v1.34, we should replace this with the tagged version. |
Member
Author
There was a problem hiding this comment.
The volcano version is compatible with v1.34 has not been released yet: volcano-sh/volcano#4671.
So, I pinned the hash tag and it is safe for us since we use just volcano APIs which means mpi-operator does not depend on the volcano mechanism.
tenzen-y
changed the title
terrytangyuan
approved these changes
Oct 30, 2025
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded the K8s dependency versions to v1.34 in the Go modules and Test Environment.
As end user benefits, they can leverage the following Features:
.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.containers[*].env.valueFrom.fileKeyRef.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.initContainers[*].env.valueFrom.fileKeyRef.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.ephemeralContainers[*].env.valueFrom.fileKeyRef.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.containers[*].restartPolicyRules.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.initContainers[*].restartPolicyRules.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.ephemeralContainers[*].restartPolicyRules.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.hostnameOverride.spec.mpiReplicaSpecs.[Launche|Worker].template.spec.volumes[*].projected.sources[*].podCertificate