Skip to content

Conversation

@Misha6Sharma
Copy link

updated kustomization.yaml and fixed deprecated fields for dashboard components

@Misha6Sharma Misha6Sharma changed the title Fixing in kubeflow/dashboard fix(dashboard): update kustomization.yaml and deprecated fields Nov 6, 2025
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Misha6Sharma

Appreciate you making this contribution 💯

To help facilitate the review - may I politely ask that you provide before + after (and ideally a "diff" view) of rendering the various manifests. You can attach those artifacts as a comment on the PR itself.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Misha6Sharma
Copy link
Author

@andyatmiami
Thank you for reverting back , given below are the before after + the diff view files for you to review

PodDefaults Webhook (Overlay)
before - poddefaults-before.yaml
after - poddefaults-after.yaml
diff - poddefaults-diff.txt

Profile Controller (Base)
before - profile-base-before.yaml
after - profile-base-after.yaml
diff - profile-base-diff.txt

Profile Controller (Overlay)
before - profile-overlay-before.yaml
after - profile-overlay-after.yaml
diff - profile-overlay-diff.txt

Profile Controller (CRD)
before - profile-crd-before.yaml
after - profile-crd-after.yaml
diff - profile-crd-diff.txt

Profile Controller (Default)
before - profile-default-before.yaml
after - profile-default-after.yaml
diff - profile-default-diff.txt

Attached Files:
poddefaults-before.yaml

poddefaults-after.yaml

poddefaults-diff.txt

profile-base-before.yaml

profile-base-after.yaml

profile-base-diff.txt

profile-overlay-before.yaml

profile-overlay-after.yaml

profile-overlay-diff.txt

profile-crd-before.yaml

profile-crd-after.yaml

profile-crd-diff.txt

profile-default-before.yaml

profile-default-after.yaml

profile-default-diff.txt

@Misha6Sharma
Copy link
Author

Hi , so am basically I am tryna fix the checks that failed . So I was trying to fix the podDefaults Integration Test
Something is actaully wrong with my (crd.yaml ) file components/poddefaults-webhooks/manifests/base/crd.yaml
The kustomize build fails with line
Error: map[string]interface {}(nil): yaml: unmarshal errors:
line 2044: mapping key "type" already defined at line 21
but line 2044 doesn't have any 'type' it has - name there idk what's happening

Screenshot 2025-11-11 235753 Screenshot 2025-11-12 001040

Could this be environment testing error or because the test fails prior to it weren't fixed properly
Please help and guide futher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants