Skip to content

fix: iframe synchronization #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix: iframe synchronization #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/centraldashboard/public/components/iframe-container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ export class IframeContainer extends PolymerElement {
// Adds a click handler to be able to capture navigation events from
// the captured iframe and set the page property which notifies
const iframe = this.$.iframe;
iframe.addEventListener('load', () => {
iframe.addEventListener('load', (event) => {
const nextLocation = event.target.contentWindow.location;
const nextIframePage = nextLocation.href.slice(
nextLocation.origin.length);
this.page = nextIframePage;
const syncIframePage = () => {
const iframeLocation = iframe.contentWindow.location;
const newIframePage = iframeLocation.href.slice(
Expand Down
1 change: 0 additions & 1 deletion components/centraldashboard/public/components/main-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,6 @@ export class MainPage extends utilitiesMixin(PolymerElement) {
}
}
window.history.replaceState(null, null, l.toString());
this.set('routeHash.path', window.location.hash.substr(1));
}

/**
Expand Down
Loading