-
Notifications
You must be signed in to change notification settings - Fork 176
UpdateDoc: add integrate edgecore with systemd in Install KubeEdge With Binary section #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @FengGaoCSC! It looks like this is your first PR to kubeedge/website 🎉 |
Summary of ChangesHello @FengGaoCSC, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the KubeEdge documentation, specifically for binary installations. It introduces comprehensive steps for integrating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the KubeEdge documentation, primarily to add instructions for integrating edgecore with systemd when installed from a binary. It also includes several minor fixes, such as correcting command syntax and clarifying instructions. The changes are generally positive, but I've identified a few areas in docs/setup/install-with-binary.md with grammatical errors and opportunities to make the new instructions more robust and clear. My feedback focuses on improving the clarity and correctness of the documentation.
|
@FengGaoCSC thanks! @Shelley-BaoYue you can go ahead to sign me up on this for review! |
|
@FengGaoCSC besides comments, it is missing DCO, can you |
… some minor bugs fix Signed-off-by: FengGaoCSC <[email protected]>
085677a to
984ccc9
Compare
…ith systemd and some minor bugs fix Signed-off-by: FengGaoCSC <[email protected]>
Signed-off-by: FengGaoCSC <[email protected]>
Shelley-BaoYue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you both for your contributions.
@FengGaoCSC Would you like to become KubeEdge member? If so, you can submit a membership request issue in https://github.com/kubeedge/community/issues.
@fujitatomoya Would you like to become a reviewer both for kubeedge/kubeedge repo and kubeedge/website repo? If so, welcome to submit PR to request for it : )
Thanks again for your contributions!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Shelley-BaoYue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
willing to do that, i will submit the request. |
|
according to https://github.com/kubeedge/community/blob/master/community-membership.md#member, i need one more approval. @kevin-wangzefeng can you second this? |
… Add integrate edgecore with systemd in Install KubeEdge with binary and some minor bugs fix
Which issue(s) this PR fixes:
Some minor command spelling error like :
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update:
Add integrate edgecore with systemd in Install KubeEdge With Binary section
What is the current behavior? (You can also link to an open issue here)
N/A
What is the new behavior (if this is a feature change)?
N/A
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
N/A
Other information: