Skip to content

Conversation

@FengGaoCSC
Copy link

… Add integrate edgecore with systemd in Install KubeEdge with binary and some minor bugs fix

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Some minor command spelling error like :

> kubectl get secret -nkubeedge tokensecret -o=jsonpath='{.data.tokendata}' | base64 -d
- kubectl get secret -n kubeedge tokensecret -o=jsonpath='{.data.tokendata}' | base64 -d
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Docs update:
    Add integrate edgecore with systemd in Install KubeEdge With Binary section

  • What is the current behavior? (You can also link to an open issue here)
    N/A

  • What is the new behavior (if this is a feature change)?
    N/A

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    N/A

  • Other information:

@kubeedge-bot
Copy link
Collaborator

Welcome @FengGaoCSC! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @FengGaoCSC, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the KubeEdge documentation, specifically for binary installations. It introduces comprehensive steps for integrating the edgecore component with systemd, ensuring robust and manageable edge node operations. Additionally, it refines existing instructions by correcting minor command syntax errors and clarifying download procedures, thereby improving the overall accuracy and user experience of the installation guide.

Highlights

  • Systemd Integration for Edgecore: New documentation has been added to guide users on how to integrate the edgecore binary with systemd for persistent service management, including creating a service file and using systemctl commands.
  • Documentation Clarity Improvements: Minor textual clarifications have been made, including specifying correct release binary versions for downloads and fixing kubectl command syntax errors.
  • Configuration Path Update: The default configuration file generation for edgecore now correctly points to /etc/kubeedge/config/edgecore.yaml, aligning with standard system practices.
  • Pause Image Tag Update: The kubeedge/pause image tags in the documentation have been generalized from specific version 3.1 to a more flexible 3.x for various architectures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@FengGaoCSC
Copy link
Author

@fujitatomoya

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the KubeEdge documentation, primarily to add instructions for integrating edgecore with systemd when installed from a binary. It also includes several minor fixes, such as correcting command syntax and clarifying instructions. The changes are generally positive, but I've identified a few areas in docs/setup/install-with-binary.md with grammatical errors and opportunities to make the new instructions more robust and clear. My feedback focuses on improving the clarity and correctness of the documentation.

@fujitatomoya
Copy link
Contributor

@FengGaoCSC thanks!

@Shelley-BaoYue you can go ahead to sign me up on this for review!

@fujitatomoya
Copy link
Contributor

@FengGaoCSC besides comments, it is missing DCO, can you signoff?

…ith systemd and some minor bugs fix

Signed-off-by: FengGaoCSC <[email protected]>
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2025
Signed-off-by: FengGaoCSC <[email protected]>
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2025
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thank you both for your contributions.

@FengGaoCSC Would you like to become KubeEdge member? If so, you can submit a membership request issue in https://github.com/kubeedge/community/issues.

@fujitatomoya Would you like to become a reviewer both for kubeedge/kubeedge repo and kubeedge/website repo? If so, welcome to submit PR to request for it : )

Thanks again for your contributions!

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Shelley-BaoYue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@fujitatomoya
Copy link
Contributor

@Shelley-BaoYue

Would you like to become a reviewer both for kubeedge/kubeedge repo and kubeedge/website repo? If so, welcome to submit PR to request for it : )

willing to do that, i will submit the request.

@fujitatomoya
Copy link
Contributor

@Shelley-BaoYue

according to https://github.com/kubeedge/community/blob/master/community-membership.md#member, i need one more approval. @kevin-wangzefeng can you second this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants