Skip to content

Conversation

@suqin9
Copy link

@suqin9 suqin9 commented Apr 10, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #665

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature: Add reusable PartnerCard component and update partners page to use cards instead of table layout.

  • What is the current behavior? (You can also link to an open issue here)

The partners page displays all partner information in a markdown table, which lacks flexibility and is not visually consistent with modern UI expectations.

  • What is the new behavior (if this is a feature change)?

Introduces a PartnerCard React component to render each partner's info in card layout with description truncation, expandable content, and link to website. The table layout has been replaced with responsive cards.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

  • Other information:

This PR enhances the visual layout and maintainability of the partners page. The new structure allows adding partner cards via React components, making it easier to extend in the future.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Collaborator

Welcome @suqin9! It looks like this is your first PR to kubeedge/website 🎉

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2025
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! Looks like the Partners page has been optimized a lot. Welcome to communicate more details at Community Meeting, 16:00 every Wednesday.

@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2025
margin: '10px',
width: '100%',
maxWidth: '380px',
height: hovered ? '360px' : '260px', // 加高
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use any Chinese comments

label: 'HardwareList',
to: '/hardware-list',
position: 'left',
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardware compatibility testing has not started yet. We can hide this page in thie PR. Tutorials page can also be hiden first. Ref to the job center page at L174-180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Community Website Comprehensive Upgrade Project: Homepage Renewal and Expansion of Core Pages

3 participants