Stabilise runtime predicates #1578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are unlikely to undergo much changes (and they are basically a completely separate part in the codebase). This should be an easy feature cleanup in runtime, and one less need for unstable-runtime for common setups (i use this all the time).
This removes the
kube_runtime/unstable-runtime-predicates
feature and thus removes the need for users to usekube/unstable-runtime
if they only are usingpredicates
.Public api wise; this exposes the
Predicate
trait, theWatchStreamExt::predicate_filter
fn, and by necessity the (unconstructible)PredicateFilter
stream wrapper type.(Not planning on merging until near the release cycle in case any more fixes come in).
Idea via kube-rs/controller-rs#50 (comment)