Skip to content

chore: bump up kopium #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

chore: bump up kopium #169

merged 1 commit into from
Aug 24, 2025
+2 −2

Conversation

hhcs9527
Copy link
Contributor

Summary

  • Update README for kopium v0.21.3.

  • Verified no errors occur when running:

    ./update.sh
cargo rustdoc --features k8s-openapi/v1_31 -p gateway-api

Related Issues

Notes for Reviewer

@hhcs9527
Copy link
Contributor Author

Hi @shaneutt @clux ,
Please help check this issue when you are available, thanks!

@hhcs9527 hhcs9527 force-pushed the chore/bump-kopium-version branch from b5d471a to fb303cc Compare August 20, 2025 15:53
shaneutt
shaneutt requested changes Aug 20, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR!

Unfortunately this seems to be undoing the work that was recently done in #160 🤔

Was there something that was getting in your way?

@hhcs9527 hhcs9527 force-pushed the chore/bump-kopium-version branch from fb303cc to 679ef8d Compare August 24, 2025 14:29
@shaneutt shaneutt self-assigned this Aug 24, 2025
@shaneutt shaneutt moved this to Review in gateway-api-rs Aug 24, 2025
@shaneutt shaneutt added this to the v0.25.0 milestone Aug 24, 2025
@shaneutt shaneutt linked an issue Aug 24, 2025 that may be closed by this pull request
Promote URLs to hyperlinks in Rustdocs #64
Open
@shaneutt shaneutt self-requested a review August 24, 2025 14:35
shaneutt
shaneutt approved these changes Aug 24, 2025
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for sorting this out!

@shaneutt shaneutt merged commit 29da2db into kube-rs:main Aug 24, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in gateway-api-rs Aug 24, 2025
@hhcs9527
Copy link
Contributor Author

Hi @shaneutt ,
I think you are right, and thank you for helping to resolve the README issue.
However, I found that the error in this issue is still not fully resolved. I manually added <> to ensure it doesn’t happen again, which is why I created this PR.
Thanks again for your help!

@shaneutt
Copy link
Member

Thanks for the update, I re-opened #64 so we can continue to poke at it 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

Assignees

@shaneutt shaneutt

Labels
area/maintenance
Projects
gateway-api-rs
Status: Done
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.

Promote URLs to hyperlinks in Rustdocs
3 participants
@hhcs9527 @shaneutt @pohanhuangtw