Skip to content

Adding support for graceful and faster closing on Huawei SmartAX. #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2025
Merged

Adding support for graceful and faster closing on Huawei SmartAX. #3685

merged 5 commits into from
Jun 2, 2025

Conversation

@evilmonkey19
Copy link
Contributor

@evilmonkey19 evilmonkey19 commented May 29, 2025

Related to #3681

Adding a graceful and faster closing for Huawei SmartAX. If for any reason gets stuck it timeouts after 30 seconds.

This is the log:


OLT#

OLT#quit
quit 
  Check whether system data has been changed. Please save data before logout. Are you sure to log out? (y/n)[n]:y
y

  Configuration console exit, please retry to log on

@ktbyers
Copy link
Owner

ktbyers commented Jun 2, 2025 •
edited
Loading

@evilmonkey19 Let me know what you think about adding the is_alive() call as per below?

ktbyers
ktbyers requested changes Jun 2, 2025
View reviewed changes
@evilmonkey19
Copy link
Contributor Author

evilmonkey19 commented Jun 2, 2025

Added your suggestion! It works perfectly :)

@ktbyers ktbyers merged commit 8dc3ba4 into ktbyers:develop Jun 2, 2025
17 checks passed
@evilmonkey19 evilmonkey19 mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktbyers ktbyers ktbyers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evilmonkey19 @ktbyers