Patterns for DellOS10, OS9, Extreme and PowerConnect terminal improvement #3678
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed spaces into zero or more whitespace in pattern
feature: Dell OS10 SmartFabric added to autodetect.
adrianlasota
changed the title
ktbyers
approved these changes
May 22, 2025
Owner
|
LGTM. @adrianlasota Thanks for the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to improve device compatibility and enhance the accuracy of SSH autodetection in the
netmikolibrary. The changes include adjustments to paging commands for Dell devices, updates to search patterns for device detection, and minor improvements to handle variations in device responses.Dell device compatibility improvements:
netmiko/dell/dell_powerconnect.py: Added an additional paging command (terminal length 0) for Dell 7xxx series devices and included a buffer clearing step to ensure reliable communication.SSH autodetection enhancements:
netmiko/ssh_autodetect.py: Updated search patterns fordell_os9to include a new variant (Dell EMC Networking OS Version\s*:\s*9) and refined existing patterns for better matching.netmiko/ssh_autodetect.py: Enhanced search patterns fordell_os10to detect additional naming conventions such asDell SmartFabric OS10-Enterprise.netmiko/ssh_autodetect.py: Added a new search pattern (EXOS) forextreme_exosto account for alternative device identifiers.