Fix useBuffer() targetView assignment #168
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The useBuffer() method was not properly initializing the module-level targetView variable, causing
TypeError: undefined is not an object (evaluating 'targetView.setFloat64')
and similar errors when packing data that requires DataView operations.Root Cause
When useBuffer(buffer) is called, it correctly sets:
Later, when pack() executes, it checks if (!target) to decide whether to initialize. Since target is already set by useBuffer(), the initialization block that sets targetView = target.dataView is skipped, leaving targetView undefined.
Fix
Added targetView = target.dataView to useBuffer() to ensure both target and targetView are properly initialized when using external buffers.
This enables proper buffer reuse patterns and prevents runtime errors when packing numbers, which require DataView methods like setFloat64(), setUint32(), etc.