Skip to content

Conversation

kraj
Copy link
Owner

@kraj kraj commented Jul 18, 2025


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

kraj added 2 commits July 17, 2025 19:20
They should be set by distros not by meta-clang
since distros decide to use clang as system compiler

Signed-off-by: Khem Raj <[email protected]>
Some of these settings are moved to OE-core and some are deferred to
distros where it belongs. This makes meta-clang compatible with YP
again.

Signed-off-by: Khem Raj <[email protected]>
Copy link
Contributor

@shr-project shr-project left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were also causing failures for builds with target toolchain gcc as reported on #yocto 2025-07-14

23:17 < JaMa> khem: there is small issue with rust (and rust-llvm) when building with meta-clang, the bbappend there sets TOOLCHAIN_NATIVE to clang, so clang-native is inheritted (even for target builds) and target builds with gcc fail, because they don't recognize --rtlib=libgcc --unwindlib=libgcc when target CC is gcc-cross, I guess you're not seeing this because most builds with meta-clang will use clang also for target
23:17 < JaMa> builds
23:17 < JaMa> not sure what's the correct fix, should clang-native append LDFLAGS only for class-native?

So good I won't need to BBMASK them anymore, thanks :).

kraj added 2 commits July 18, 2025 21:48
Its moved into klibc.bbclass in meta-initramfs

Signed-off-by: Khem Raj <[email protected]>
This should be part of default tune infra in core

Signed-off-by: Khem Raj <[email protected]>
kraj added 4 commits July 20, 2025 23:32
This patch is not needed anymore with clang 20+ and samba 4.19+
it build fine with both linkers ( LLD and Gnu LD)

Signed-off-by: Khem Raj <[email protected]>
Set TOOLCHAIN_NATIVE = "clang" in disrto conf files not here

Signed-off-by: Khem Raj <[email protected]>
These are not supported by clang, but now they are handled in core
tune files.

Signed-off-by: Khem Raj <[email protected]>
Its working again

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit ba170af into kraj:master Jul 28, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants