WIP: Remove asyncache dependency #695
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncache is only used for one function, maintaining the library to decorate one function is not worth it (I believe, I don't know the roadmap 😄)
I didn't set up the pytest infrastructure yet (but I did half-ass try), Nix is inherently incompatible with it since it's running kind which you can't do within the Nix build container. (Not "easily" at least) so this is untested too, but I think the change is worth consideration. It's a bit less fluffy magic but easier to comprehend and you don't have to maintain asyncache anymore 😄
Fixes these warnings from latest CI run:
If there are plans to expand asyncache usage feel free to discard this 😄