Update version-support.md via update-kubernetes script #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
for more information, see https://pre-commit.ci
Comment on lines
+145
to
+154
| def format_sources(existing, new): | ||
| items = [ | ||
| s.strip().lstrip("-").strip() | ||
| for s in existing.replace("<br>", ",").split(",") | ||
| if s.strip() | ||
| ] | ||
| # Add new provider if not already present | ||
| if new not in items: | ||
| items.append(new) | ||
| return " <br> - " + " <br> - ".join(items) |
Member
There was a problem hiding this comment.
This function seems out of place. Why is it being defined in here?
Author
There was a problem hiding this comment.
I tried to add this function as a formatter for displaying the service sources names for any version.
Member
There was a problem hiding this comment.
Sure, but defining this as a function within another function is a little strange given that it doesn't require any variables from the scope of the parent function. It would be best to define this at the module level.
Comment on lines
+156
to
+164
| if ( | ||
| "Extended Support" in existing_source | ||
| and provider not in existing_source | ||
| ): | ||
| version["support_source"] = format_sources( | ||
| existing_source, provider | ||
| ) | ||
| elif existing_source == "OSS Standard Support": | ||
| version["support_source"] = f"- {provider} Extended Support" |
Member
There was a problem hiding this comment.
This code is a little hard to follow, I expect there is a simpler way to implement this. The goal here should be to show which providers are extending the support of each version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how the version support table is gonna look like.
Link to the issue - #656
The script is formatted such that it can look up any changes in the version support added to the main application and make necessary changes to the table.