Skip to content

Conversation

@FredHaa
Copy link
Contributor

@FredHaa FredHaa commented Mar 28, 2025

This pull request includes updates to the minimum required CMake version across various files to ensure compatibility with newer features. The most important changes are:

Updates to CMake version requirements:

Dependency updates:

  • pyproject.toml: Modified the required CMake version to be at least 3.10.

@DanielArmyrConversy
Copy link

DanielArmyrConversy commented Mar 28, 2025

Does this also build on a system that has cmake 4.0 availible? I see that you added min version 3.10, but is cmake 4 compatible with 3.10? It says in the error message that min version has to be 3.5 at least?

To be clear, I have not tested, just guessing here.

@FredHaa
Copy link
Contributor Author

FredHaa commented Mar 28, 2025

The error about version 3.5 being required came from the package just pulling the latest cmake 4.0 which is not compatible with cmake 3.1 specified in the CMakeLists.txt file.

First I changed the minimum version to 3.5, but I got a deprecation warning, so I set it to 3.10 instead.

@DanielArmyrConversy
Copy link

Feels backwards to me, but this is not my expertise, and if it works, it works. My solution means that the latest version fo cmake would not be supported, with would only push the problem to the future.

@FredHaa
Copy link
Contributor Author

FredHaa commented Mar 28, 2025

It works in my GitHub action workflow at least, as well as locally.

@FredHaa
Copy link
Contributor Author

FredHaa commented Mar 28, 2025

Fixes #462

@ydshieh
Copy link

ydshieh commented Mar 28, 2025

Confirmed it (this PR) works for huggingface/transformers CI doker image build too. Thank you and hopefully this could be merged with a release 🙏

@ydshieh
Copy link

ydshieh commented Mar 28, 2025

Hi @kpu Would it be possible to merge this quickly? That would be great if we could 🙏

@kpu kpu merged commit ba83eaf into kpu:master Mar 30, 2025
1 of 3 checks passed
@chrisjbryant
Copy link

Any chance this could also be pushed to PyPi as well? 🙏

@JakobHavtorn
Copy link

Any chance this could also be pushed to PyPi as well? 🙏

I'd like to second, third, and fourth that ^ 🙏🤞

@FredHaa FredHaa deleted the fix-build-with-cmake-4.0 branch April 2, 2025 10:27
@FredHaa FredHaa restored the fix-build-with-cmake-4.0 branch April 2, 2025 10:27
@chrisjbryant
Copy link

Tagging @kpu just to make sure you received the request, since I think a bunch of folks would really appreciate a PyPi update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants