-
Notifications
You must be signed in to change notification settings - Fork 532
Fix build with cmake 4.0 #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does this also build on a system that has cmake 4.0 availible? I see that you added min version 3.10, but is cmake 4 compatible with 3.10? It says in the error message that min version has to be 3.5 at least? To be clear, I have not tested, just guessing here. |
|
The error about version 3.5 being required came from the package just pulling the latest cmake 4.0 which is not compatible with cmake 3.1 specified in the CMakeLists.txt file. First I changed the minimum version to 3.5, but I got a deprecation warning, so I set it to 3.10 instead. |
|
Feels backwards to me, but this is not my expertise, and if it works, it works. My solution means that the latest version fo cmake would not be supported, with would only push the problem to the future. |
|
It works in my GitHub action workflow at least, as well as locally. |
|
Fixes #462 |
|
Confirmed it (this PR) works for huggingface/transformers CI doker image build too. Thank you and hopefully this could be merged with a release 🙏 |
|
Hi @kpu Would it be possible to merge this quickly? That would be great if we could 🙏 |
|
Any chance this could also be pushed to PyPi as well? 🙏 |
I'd like to second, third, and fourth that ^ 🙏🤞 |
|
Tagging @kpu just to make sure you received the request, since I think a bunch of folks would really appreciate a PyPi update! |
This pull request includes updates to the minimum required CMake version across various files to ensure compatibility with newer features. The most important changes are:
Updates to CMake version requirements:
CMakeLists.txt: Updated the minimum CMake version from 3.1 to 3.10.python/BuildStandalone.cmake: Updated the minimum CMake version from 3.1 to 3.10.Dependency updates:
pyproject.toml: Modified the required CMake version to be at least 3.10.