Skip to content

Make fallthroughs explicit in murmur_hash.cc #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make fallthroughs explicit in murmur_hash.cc #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions util/murmur_hash.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ uint64_t MurmurHash64A ( const void * key, std::size_t len, uint64_t seed )

switch(len & 7)
{
case 7: h ^= uint64_t(data2[6]) << 48;
case 6: h ^= uint64_t(data2[5]) << 40;
case 5: h ^= uint64_t(data2[4]) << 32;
case 4: h ^= uint64_t(data2[3]) << 24;
case 3: h ^= uint64_t(data2[2]) << 16;
case 2: h ^= uint64_t(data2[1]) << 8;
case 7: h ^= uint64_t(data2[6]) << 48; [[fallthrough]];
case 6: h ^= uint64_t(data2[5]) << 40; [[fallthrough]];
case 5: h ^= uint64_t(data2[4]) << 32; [[fallthrough]];
case 4: h ^= uint64_t(data2[3]) << 24; [[fallthrough]];
case 3: h ^= uint64_t(data2[2]) << 16; [[fallthrough]];
case 2: h ^= uint64_t(data2[1]) << 8; [[fallthrough]];
case 1: h ^= uint64_t(data2[0]);
h *= m;
};
Expand Down Expand Up @@ -133,8 +133,8 @@ uint64_t MurmurHash64B ( const void * key, std::size_t len, uint64_t seed )

switch(len)
{
case 3: h2 ^= ((unsigned char*)data)[2] << 16;
case 2: h2 ^= ((unsigned char*)data)[1] << 8;
case 3: h2 ^= ((unsigned char*)data)[2] << 16; [[fallthrough]];
case 2: h2 ^= ((unsigned char*)data)[1] << 8; [[fallthrough]];
case 1: h2 ^= ((unsigned char*)data)[0];
h2 *= m;
};
Expand Down