Implement a max_retries option #196
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for rebuilders set an upper limit for the number of times BAD packages will be retried.
Currently, bad packages are retried indefinitely, taking up queue space and valuable server time. In most cases, a BAD build will never become GOOD, and as such it's been an oft-requested feature to turn that indefinite retry off.
With these changes, administrators can configure the maximum number of allowed retries on packages in the configuration file. It does not presently distinguish between retries on BAD vs FAIL packages, but that is an enhancement we can make in the future.