Skip to content

Skip docker verify, the api may not be available sometimes #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszo merged 1 commit into from
Apr 29, 2026
Merged

Skip docker verify, the api may not be available sometimes #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/koyeb/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ func (h *ServiceHandler) addServiceDefinitionFlagsForGitSource(flags *pflag.Flag
func (h *ServiceHandler) addServiceDefinitionFlagsForDockerSource(flags *pflag.FlagSet) {
flags.String("docker", "", "Docker image")
flags.String("docker-private-registry-secret", "", "Docker private registry secret")
flags.Bool("skip-docker-verify", false, "Skip docker image verification")
Copy link
Copy Markdown
Contributor

@nicoche nicoche Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-skip-verify to match the other flags?

flags.StringSlice("docker-entrypoint", []string{}, "Docker entrypoint. To provide multiple arguments, use the --docker-entrypoint flag multiple times.")
flags.String("docker-command", "", "Set the docker CMD explicitly. To provide arguments to the command, use the --docker-args flag.")
flags.StringSlice("docker-args", []string{}, "Set arguments to the docker command. To provide multiple arguments, use the --docker-args flag multiple times.")
Expand Down Expand Up @@ -1604,8 +1605,11 @@ func (h *ServiceHandler) parseDockerSource(ctx *CLIContext, flags *pflag.FlagSet
if flags.Lookup("docker").Changed {
image, _ := flags.GetString("docker")
source.SetImage(image)
if err := h.checkDockerImage(ctx, source); err != nil {
return nil, err
skipVerify, _ := flags.GetBool("skip-docker-verify")
if !skipVerify {
if err := h.checkDockerImage(ctx, source); err != nil {
return nil, err
}
}
}
if flags.Lookup("docker-args").Changed {
Expand Down
Loading