Atomic cache writes and deduplicate AuthTest on startup#256
Closed
mark-liu wants to merge 1 commit intokorotovsky:masterfrom
Closed
Atomic cache writes and deduplicate AuthTest on startup#256mark-liu wants to merge 1 commit intokorotovsky:masterfrom
mark-liu wants to merge 1 commit intokorotovsky:masterfrom
Conversation
Two fixes for running multiple MCP server instances concurrently: 1. Cache files (users, channels) are now written atomically via write-to-temp-then-rename. Previously os.WriteFile could leave partial 400MB+ JSON files visible to concurrent readers. 2. validateAuthAndGetTeamID now returns the full AuthTestResponse which is passed to NewMCPSlackClient, eliminating a redundant AuthTest API call per startup (2 per instance down to 1). Signed-off-by: Mark Liu <mark@prove.com.au>
This was referenced Mar 26, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #254 and #255.
Two fixes for running multiple MCP server instances concurrently (e.g. Claude Code launching separate instances per workspace):
Cache files are now written atomically via write-to-temp-then-rename. Previously
os.WriteFileon 300-460MB JSON files could leave partial data visible to concurrent readers.validateAuthAndGetTeamIDnow returns the fullAuthTestResponsewhich is passed intoNewMCPSlackClient, eliminating a redundantAuthTestAPI call per startup (2 per instance down to 1). Reduces rate limit pressure when multiple instances start simultaneously.No new dependencies. Backwards compatible —
NewMCPSlackClientacceptsnilforcachedAuthand falls back to callingAuthTestitself.