feat: add query and query_targets parameters to channels_list tool#252
Open
unsafe9 wants to merge 3 commits intokorotovsky:masterfrom
Open
feat: add query and query_targets parameters to channels_list tool#252unsafe9 wants to merge 3 commits intokorotovsky:masterfrom
unsafe9 wants to merge 3 commits intokorotovsky:masterfrom
Conversation
Closes korotovsky#251. Adds keyword filtering to channels_list so users can find channels without paginating through the entire list. Matches are case-insensitive substrings; query_targets controls which fields to search (name by default, optionally topic and purpose).
Use map[string]bool instead of struct, parse inline in handler with warn logging for invalid values, matching filterChannelsByTypes style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryparameter for case-insensitive keyword filtering onchannels_listquery_targetsparameter to control which fields are searched (nameby default, optionallytopic,purpose)Closes #251
Test plan
TestIntegrationChannelsListQueryFilterverifies filtering withquery=testcasequeryalone defaults to name-only matchingquery_targets=name,topic,purposebroadens the searchchannels_listbehavior withoutquery