docs: fix incorrect env var references for reactions and add missing tool env vars#245
Open
coolwuu wants to merge 1 commit intokorotovsky:masterfrom
Open
Conversation
…tool env vars The `reactions_add` and `reactions_remove` tools are gated by `SLACK_MCP_REACTION_TOOL` in the code (server.go), but the README incorrectly references `SLACK_MCP_ADD_MESSAGE_TOOL` for enabling them. Additionally, `SLACK_MCP_REACTION_TOOL` and `SLACK_MCP_ATTACHMENT_TOOL` are missing from the Environment Variables table entirely. Changes: - Fix `reactions_add` note to reference `SLACK_MCP_REACTION_TOOL` - Fix `reactions_remove` note to reference `SLACK_MCP_REACTION_TOOL` - Add `SLACK_MCP_REACTION_TOOL` row to the env var table - Add `SLACK_MCP_ATTACHMENT_TOOL` row to the env var table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README incorrectly tells users to set
SLACK_MCP_ADD_MESSAGE_TOOLto enablereactions_addandreactions_remove, but the code (pkg/server/server.goandpkg/handler/conversations.go) gates these tools behindSLACK_MCP_REACTION_TOOL. Users following the README cannot enable reaction tools.Additionally,
SLACK_MCP_REACTION_TOOLandSLACK_MCP_ATTACHMENT_TOOLare completely absent from the Environment Variables table.Changes
reactions_addtool note (line 91) to referenceSLACK_MCP_REACTION_TOOLinstead ofSLACK_MCP_ADD_MESSAGE_TOOLreactions_removetool note (line 101) to referenceSLACK_MCP_REACTION_TOOLinstead ofSLACK_MCP_ADD_MESSAGE_TOOLSLACK_MCP_REACTION_TOOLrow to the Environment Variables table (supportstrue, channel ID whitelist, and!exclusion — matchingisChannelAllowedForConfiglogic)SLACK_MCP_ATTACHMENT_TOOLrow to the Environment Variables table (supportstrue/1/yesonly — no channel-level restrictions, matchingparseParamsToolFilesGetlogic)Code references
pkg/server/server.go:189—shouldAddTool(ToolReactionsAdd, enabledTools, "SLACK_MCP_REACTION_TOOL")pkg/server/server.go:208—shouldAddTool(ToolReactionsRemove, enabledTools, "SLACK_MCP_REACTION_TOOL")pkg/server/server.go:227—shouldAddTool(ToolAttachmentGetData, enabledTools, "SLACK_MCP_ATTACHMENT_TOOL")pkg/handler/conversations.go:1721—toolConfig := os.Getenv("SLACK_MCP_REACTION_TOOL")pkg/handler/conversations.go:1769—toolConfig := os.Getenv("SLACK_MCP_ATTACHMENT_TOOL")