Skip to content

Patch 1#3

Draft
kornmuas wants to merge 604 commits intoadd-in-contributingfrom
patch-1
Draft

Patch 1#3
kornmuas wants to merge 604 commits intoadd-in-contributingfrom
patch-1

Conversation

@kornmuas
Copy link
Owner

Pre-requisites

  • Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • Should include comments in the workflow for any parts that are not obvious or could use clarification.

For CI workflows, the workflow:

  • Should be preserved under the ci directory.
  • Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • Packaging workflows should run on release with types: [ created ].
  • Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

  • Should be preserved under the code-scanning directory.
  • Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
    • name: Name of the Code Scanning integration.
    • organization: Name of the organization producing the Code Scanning integration.
    • description: Short description of the Code Scanning integration.
    • categories: Array of languages supported by the Code Scanning integration.
    • iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
  • Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • Automation and CI workflows cannot be dependent on a paid service or product.

maximousblk and others added 30 commits August 25, 2020 13:24
Ada starter workflow, icon and properties
…to-ghcr

Update Publish Docker template to publish to GitHub Container Registry
Update to use the $registry-url() token
On analyzing the code with `pylint`, the name of the step is `Test with pytest`, which is certainly not what it does.
Fix on step name for pylint action
With GitHub Packages everything is ok, but we had a problem with "bearer" in the RubyGems step.
We solved when we removed the bearer in the ruby gem step.
Is it ok?

Repo with our test (https://github.com/rubynetti/amico-db)
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
The ID isn't used in other steps of the script
chore: Remove id for go install
 it looks like someone tried to use '' to make a ' happen for the possessive tense of users. But that messes up the quoting:
issue-message: 'Message that will be displayed on users'' first issue'
pr-message: 'Message that will be displayed on users'' first pr'

It should be:
issue-message: 'Message that will be displayed on the first issue for that user'
pr-message: 'Message that will be displayed on the first pr for that user'

(this gets rid of the spurious quotes, but also doesn't introduce any grammatical errors)

It was a very bad impression to have a simple script designed to welcome folks be broken by default.
sampart and others added 30 commits April 20, 2021 09:42
The instruments command is deprecated as of Xcode 12 (https://developer.apple.com/documentation/xcode-release-notes/xcode-12-release-notes). Updated to use the corresponding `xcrun` command.
PSScriptAnalyzer code scanning
Update starter workflows to specify required permissions
Enhance/update the cmake starter workflow
The tfsec action doesn't require the GitHub token so removing it
Do not use fail-fast when testing multiple Pythons
`instruments` is depreacted, update to use `xcrun xctrace`
As oc-new-app action now has 'port' as an optional input
So, removing default value of env 'APP_PORT'

Signed-off-by: divyansh42 <diagrawa@redhat.com>
update setup-msbuild version and fix add path bug.
Use the latest commit hash for the action - resolves the issue support code signing
* switch to official denoland/setup-deno action

Also adds formatting and linting to the workflow (like dart workflow), and use uniform capitalization.

* update commit hash

Co-authored-by: Josh Gross <joshmgross@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.