refactor1 #208
refactor1 #208
Conversation
![ed-codegen[bot]](https://avatars.githubusercontent.com/u/28070492?s=60&v=4){kind=small}
| constant process of faulty replication. This process corresponds to what happens | ||
| to Johnny in the narrative when he loses his own memories due to the overload of | ||
| information in his brain. | ||
| this sucks |
There was a problem hiding this comment.
Consider adding more informative comments. The statement 'this sucks' and 'this does not sucks as much' don't provide context or constructive criticism. If something in the code or design isn't working for you, it would be helpful to provide further details. This will make it easier for other contributors to help resolve any issues.
| The Memoria project is implemented using Python and the VLC media player. The | ||
| main components of the project include: | ||
|
|
||
| this does not sucks as much |
There was a problem hiding this comment.
Noticing that the statement 'this does not sucks as much' appears to be a new insertion, but it's not clear what it's intended to refer to. Providing more context or creating a more specific comment will be more beneficial to the reviewers and to the future maintainers of the project.
|
Thanks for your feedback. We're working on improving the code comments based on your input. ImplementBot has started implementing these changes. We'll let you know once a new PR is available. |
|
Understood, I have shared the feedback with ImplementBot to incorporate the requested changes. It will rework the |
| constant process of faulty replication. This process corresponds to what happens | ||
| to Johnny in the narrative when he loses his own memories due to the overload of | ||
| information in his brain. | ||
| this sucks |
There was a problem hiding this comment.
The Removal of narrative explanation in lines 56 to 63 appears to harm the understanding for the need of the software and its implementation. It would be advisable to keep the project explanation detailed for other users and developers getting involved with the project in the future. Please reconsider this modification.
| constant process of faulty replication. This process corresponds to what happens | ||
| to Johnny in the narrative when he loses his own memories due to the overload of | ||
| information in his brain. | ||
| this sucks |
There was a problem hiding this comment.
The comments 'this sucks' (line 56) and 'this does not sucks as much' (line 63) are not helpful or professional. Comments should be used to briefly explain the reasoning behind code or provide useful information for other developers. Please revise these to be more descriptive and relevant for better comprehension of the codebase.
| [g1smo](https://github.com/g1smo) for all the help with the audio, thanks m8 ! | ||
|
|
||
|
|
||
| ## Made with :heart: and FOSS in :cuba: |
There was a problem hiding this comment.
The removal of the blank line at the end of the document (from line 147 to lin 142) does not conform to common Markdown practices, which often recommend having an empty line at the end of the file. It may be useful to revert this change.
No description provided.