Skip to content

Fix annotations when coming from java.lang (like @Override) - #113

Closed
jmle wants to merge 1 commit into
konveyor:mainfrom
jmle:fix-build-and-java-lang-annotations
Closed

Fix annotations when coming from java.lang (like @Override)#113
jmle wants to merge 1 commit into
konveyor:mainfrom
jmle:fix-build-and-java-lang-annotations

Conversation

@jmle

@jmle jmle commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator
  • Also, java.lang is a default package in Java and never imported. In order to match on the FQNs of annotations, we use the import list, but in this case that doesn't work. Added some conditions to make it a special case.

@jmle jmle changed the title 🐛 Fix build (Java21 needed now) and also fix annotations when coming from java.lang (like @Override) 🐛 Fix build (Java21 needed now) and also fix annotations when coming from java.lang (like @Override) Dec 5, 2024

@aufi aufi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for upstream main.

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@jmle
jmle force-pushed the fix-build-and-java-lang-annotations branch from 4cf8170 to 24adea1 Compare December 10, 2024 16:12
@jmle jmle changed the title 🐛 Fix build (Java21 needed now) and also fix annotations when coming from java.lang (like @Override) Fix annotations when coming from java.lang (like @Override) Dec 10, 2024
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 60 days.
It will remain open for visibility and reporting purposes.
Please comment if this PR is still relevant.

@github-actions github-actions Bot added the stale label Nov 4, 2025
@shawn-hurley

Copy link
Copy Markdown
Contributor

Closing as I think this is going to be pretty out of date with the current code (re AST Vistor), and is fixed in #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants