fix: remove go_package — consumers own their package paths#3
Merged
Conversation
tumberger
force-pushed
the
fix/remove-go-package
branch
from
d3b4f30 to
1db30aa
Compare
The proto repo should not declare language-specific options. Each consumer (Go CLI, TypeScript API, Python SDK) sets their own package path in their buf.gen.yaml via managed mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tumberger
force-pushed
the
fix/remove-go-package
branch
from
1db30aa to
fad3825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto repo should not declare language-specific options.
go_packageis a Go-specific concern — each consumer sets it viabuf.gen.yamlmanaged mode.Before: proto declares
go_package, every consumer overrides it.After: proto declares nothing language-specific, consumers set their own paths.
🤖 Generated with Claude Code