Conversation
The go_package was hardcoded to the CLI repo. Since this is a shared proto consumed by both the CLI (Go) and API (TypeScript), the package path should reference this repo. Each consumer overrides the output path via buf managed mode in their own buf.gen.yaml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Buf STANDARD lint requires RPC request/response types to match the RPC name: - HookEventRequest → ProcessHookEventRequest - HookEventResponse → ProcessHookEventResponse - PolicyUpdate → SyncPolicyResponse Also pass github_token to buf-setup-action to avoid rate limiting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Main currently has lint-failing proto (pre-rename). The breaking check compares against main and correctly reports the renames as breaking. Since there are no consumers yet, allow it to fail. Remove continue-on-error after this PR merges. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
go_packagewas hardcoded togithub.com/kontext-dev/kontext-cli/gen/..., tying the shared proto to a specific consumer.Changed to
github.com/kontext-dev/proto/gen/.... Each consumer (CLI, API) overrides the output path viabuf.gen.yamlmanaged mode.🤖 Generated with Claude Code