Add PropertyChangeSupport with an minimal implemention. #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no Serializable support.
Owner
Harmony is safe, you can just borrow the code.
Yes Also, please run checkstyle locally to see which code style violations you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I would like to contribute the PropertyChangeSupport class. It is a minimalist implementation. So it has no Serializable support. For the implementation itself I took the public API and implemented it myself. Sometimes as a help I looked at the Apache Harmony Project. Do I need to add the Apache license to every file? Also I hope those classes are far enough from the core.
Best regards pizza_dox_9999