feat(web): design-token Phase A — declare missing CSS vars, add Konjo scales - #209
Open
wesleyscholl wants to merge 1 commit into
Open
feat(web): design-token Phase A — declare missing CSS vars, add Konjo scales#209wesleyscholl wants to merge 1 commit into
wesleyscholl wants to merge 1 commit into
Conversation
Phase A of DESIGN_LANGUAGE.md (#208): additive-only token completion on the web platform, no literal-value replacement in existing components. - Declare --font-mono (referenced by 30+ .svelte components via var(--font-mono, monospace) but never declared, silently falling back to generic monospace instead of JetBrains Mono). - Declare --konjo-panel (referenced with a #0a0d0f fallback in 10 files/ 12 call sites, never declared; same value, now an actual token). - Add --konjo-space-1..7, --konjo-radius-xs/sm/md/lg/pill, and --konjo-text-xs/sm/base/md/lg/xl per DESIGN_LANGUAGE.md's Phase 3 spec. - Replace --glow-sm/--glow-md/--shadow-pane (zero, one, and zero consumers respectively) with --konjo-shadow-sm/md/lg and one --konjo-glow token; repoint HelpOverlay.svelte's sole --glow-md reference to --konjo-glow so nothing is left dangling. Verified: cargo build/test green, web build green, konjo-prose clean on the diff, live devtools check confirms --font-mono now resolves to JetBrains Mono and no other repo file references the removed tokens. StackCard.svelte and other legacy literal-value files are untouched; that's Phase B's decomposition, not this sprint's. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase A of the DESIGN_LANGUAGE.md proposal (#208): additive-only token completion on the web platform, scoped exactly per the doc's phased plan — no literal-value replacement in existing components, no SwiftUI changes, no new motion tokens.
--font-mono(referenced viavar(--font-mono, monospace)in 30+.sveltecomponents, never declared, silently falling back to genericmonospaceinstead of JetBrains Mono) and--konjo-panel(referenced with a#0a0d0ffallback in 10 files / 12 call sites, never declared).--konjo-space-1through-7,--konjo-radius-xs/sm/md/lg/pill,--konjo-text-xs/sm/base/md/lg/xl— values exactly as specified in the doc's Phase 3 token tables.--glow-sm(zero consumers),--glow-md(one consumer), and--shadow-pane(zero consumers) are replaced with--konjo-shadow-sm/md/lg+ one--konjo-glowtoken.HelpOverlay.svelte's sole--glow-mdreference is repointed to--konjo-glowso nothing is left dangling — verified no other file in the repo references any of the three removed tokens.Explicitly out of scope (per the doc's own phasing)
StackCard.svelteand other legacy files are untouched; that's Phase B.KonjoTheme.swiftchanges — native mirroring is Phase C, gated on Phase B shipping first.--dur-*/--ease-*set already adequate.Test plan
cargo buildclean,cargo test --workspacegreen (no Rust touched, confirmed anyway per repo convention)web(npm run build) cleankonjo-proseclean on the diff (pre-existing em dashes elsewhere inapp.cssleft untouched, out of scope for this PR)--glow-sm,--glow-md,--shadow-panenpm run devvia the Browser pane):--font-mononow resolves to"JetBrains Mono", ui-monospace, monospaceon bothAppSidebar.svelte's.shead .brandand.snav a, all new tokens resolve to their declared values, sidebar/dashboard/stack-card surfaces render pixel-identical to before (screenshot-checked)🤖 Generated with Claude Code