Skip to content

fix(core): default value fallback location #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Draft

fix(core): default value fallback location #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/core/src/command/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,13 +463,6 @@ export namespace Argv {
}
}

// assign default values
for (const { name, fallback } of Object.values(this._options)) {
if (fallback !== undefined && !(name in options)) {
options[name] = fallback
}
}

delete argv.tokens
return { ...argv, options, args, error: argv.error || '', command: this as any }
}
Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,13 @@ export class Session<U extends User.Field = never, G extends Channel.Field = nev
const { command } = argv
if (!command.ctx.filter(this)) return ''

// assign default values
for (const { name, fallback } of Object.values(command._options)) {
if (fallback !== undefined && !(name in argv.options)) {
argv.options[name] = fallback
}
}

if (this.app.database) {
if (!this.isDirect) {
await this.observeChannel(this.collect('channel', argv, new Set(['permissions', 'locales'])))
Expand Down