Skip to content

Dev #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koishi510 merged 10 commits into from
Mar 14, 2026

fix: address PR #163 Copilot review issues

961823b
Select commit
Loading
Failed to load commit list.
Merged

Dev #164

fix: address PR #163 Copilot review issues
961823b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 14, 2026 in 34s

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 52 in frontend/src/components/scene/SpritesLayer.vue

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHpJnvODKcpvU-vI&open=AZztNHpJnvODKcpvU-vI&pullRequest=164

Check warning on line 204 in frontend/src/composables/useParallax.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHosnvODKcpvU-vF&open=AZztNHosnvODKcpvU-vF&pullRequest=164

Check warning on line 10 in frontend/src/composables/useIsMobile.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHoQnvODKcpvU-vA&open=AZztNHoQnvODKcpvU-vA&pullRequest=164

Check warning on line 244 in frontend/src/composables/useParallax.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHosnvODKcpvU-vH&open=AZztNHosnvODKcpvU-vH&pullRequest=164

Check warning on line 21 in frontend/src/composables/useIsMobile.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHoQnvODKcpvU-vC&open=AZztNHoQnvODKcpvU-vC&pullRequest=164

Check warning on line 9 in frontend/src/composables/useIsMobile.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHoQnvODKcpvU-u_&open=AZztNHoQnvODKcpvU-u_&pullRequest=164

Check warning on line 11 in frontend/src/composables/useIsMobile.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHoQnvODKcpvU-vB&open=AZztNHoQnvODKcpvU-vB&pullRequest=164

Check warning on line 226 in frontend/src/composables/useParallax.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHosnvODKcpvU-vG&open=AZztNHosnvODKcpvU-vG&pullRequest=164

Check warning on line 2537 in frontend/src/components/overlay/CarPage.vue

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Text does not meet the minimal contrast requirement with its background. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHqCnvODKcpvU-vJ&open=AZztNHqCnvODKcpvU-vJ&pullRequest=164

Check warning on line 22 in frontend/src/composables/useIsMobile.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHoQnvODKcpvU-vD&open=AZztNHoQnvODKcpvU-vD&pullRequest=164

Check warning on line 23 in frontend/src/composables/useIsMobile.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHoQnvODKcpvU-vE&open=AZztNHoQnvODKcpvU-vE&pullRequest=164

Check warning on line 15 in frontend/src/main.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer top-level await over using a promise chain. 

See more on https://sonarcloud.io/project/issues?id=koishi510_MomShell&issues=AZztNHrSnvODKcpvU-vK&open=AZztNHrSnvODKcpvU-vK&pullRequest=164
View more details on SonarQubeCloud