-
Notifications
You must be signed in to change notification settings - Fork 8
[KOB-52442][Black] - new CI #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
aefd1f9
fc06bd0
67bbd37
5310f50
94174df
ea6abef
6a24d7c
662ef5e
6c654bf
61bf418
6b27900
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,52 +1,72 @@ | ||||||||||||||||
| name: CI | ||||||||||||||||
|
|
||||||||||||||||
| on: | ||||||||||||||||
| workflow_dispatch: | ||||||||||||||||
| inputs: | ||||||||||||||||
| logLevel: | ||||||||||||||||
| description: 'Log level' | ||||||||||||||||
| required: true | ||||||||||||||||
| default: 'info' | ||||||||||||||||
| type: choice | ||||||||||||||||
| options: | ||||||||||||||||
| - info | ||||||||||||||||
| - warning | ||||||||||||||||
| - debug | ||||||||||||||||
|
Comment on lines
+12
to
+14
|
||||||||||||||||
| - info | |
| - warning | |
| - debug | |
| - info | |
| - warning | |
| - debug |
Copilot
AI
Mar 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request is configured only for master, but push includes main, release, and production branches. If PRs can target those branches (especially main), the CI jobs won’t run for them; consider aligning the pull_request.branches list with push.branches.
| - master | |
| - master | |
| - main | |
| - '**-rc' | |
| - production | |
| - 'production-hotfix' | |
| - 'v*' |
Copilot
AI
Mar 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git-ref contains a hyphen, so github.event.inputs.git-ref will be parsed as an expression (subtraction) rather than a property lookup. Use bracket notation (github.event.inputs['git-ref']) or rename the input to git_ref and update the reference.
| git-ref: ${{ github.event.inputs.git-ref }} | |
| git-ref: ${{ github.event.inputs['git-ref'] }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: SonarQube | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| git-ref: | ||
| description: Git Ref (Optional) | ||
| required: false | ||
| schedule: | ||
| # Trigger at 09:30pm every Friday ICT | ||
| - cron: "30 2 * * 5" | ||
|
|
||
| push: | ||
| branches: | ||
| - 'master' | ||
| - 'main' | ||
|
|
||
| pull_request: | ||
| branches: | ||
| - 'master' | ||
| - 'main' | ||
|
|
||
| jobs: | ||
| build: | ||
| if: github.event.repository.owner.login == 'kobiton' | ||
| name: Scans | ||
| uses: kobiton/deployment/.github/workflows/sonar.yaml@master | ||
| with: | ||
| repo-name: appium-script-generator | ||
| git-ref: ${{ github.event.inputs.git-ref }} | ||
| sonar-project-key: kobiton-appium-script-generator | ||
| node-version: '20.10.0' | ||
| secrets: inherit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflow_dispatchdefines an inputlogLevel, but it isn’t used or forwarded to any job. If it’s not needed, remove it to avoid confusion; if it is needed, pass it through to the relevant reusable workflow viawith:.