[KOB-49917] Allow steps on launcher#54
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds idle delays and launcher support by introducing rotation and location helpers, updating visibility logic, and extending script generators.
- Define
ORIENTATIONSconstant for screen rotation - Introduce
Config.IDLE_DELAY_IN_MSand apply sleeps after driver actions - Add
rotateScreenandsetLocationin all TestBase implementations and update service generators
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/templates/nodejs/src/test/helper/constants.js | Add ORIENTATIONS constant for rotation |
| src/templates/nodejs/src/test/helper/base.js | Apply idle delays, add rotate/setLocation methods, adjust visibility |
| src/templates/nodejs/src/test/helper/app.js | Import ORIENTATIONS for new rotation functionality |
| src/templates/nodejs/src/test/config.js | Add IDLE_DELAY_IN_MS configuration |
| src/templates/java/TestBase.java | Mirror idle delays, rotation/location APIs, adjust visibility logic |
| src/templates/java/Config.java | Add IDLE_DELAY_IN_MS constant |
| src/templates/csharp/TestBase.cs | Mirror idle delays, rotation/location APIs, adjust visibility logic |
| src/templates/csharp/Config.cs | Add IdleDelayInMs constant |
| src/services/nodejs.js | Generate calls to rotateScreen and setLocation |
| src/services/java.js | Generate calls to new helper methods |
| src/services/csharp.js | Generate calls to new helper methods |
Comments suppressed due to low confidence (4)
src/templates/nodejs/src/test/helper/base.js:932
- The new
rotateScreen(andsetLocation) helpers lack corresponding unit or integration tests—consider adding coverage for these methods.
async rotateScreen(orientation) {
src/templates/nodejs/src/test/helper/base.js:423
- Dropped the original element visibility check (
elementIdDisplayed). This may mark hidden elements as visible—reintroduce combiningisElementVisiblewith the rect checks.
visible = rect.x >= 0 && rect.y >= 0 && rect.width > 0 && rect.height > 0
src/templates/java/TestBase.java:412
- Removed the
element.isDisplayed()check, which could cause invisible elements to be treated as visible. Consider restoring it alongside the rect validation.
visible = rect.x >= 0 && rect.y >= 0 && rect.width > 0 && rect.height > 0;
src/templates/csharp/TestBase.cs:484
- The original
element.Displayedcheck was removed—this can misreport visibility. Reapply it in combination with the rectangle bounds checks.
visible = rect.X >=0 && rect.Y >= 0 && rect.Width > 0 && rect.Height > 0;
d4rkwinz
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.