Skip to content

[KOB-49917] Allow steps on launcher#54

Merged
d4rkwinz merged 1 commit into
masterfrom
KOB-49917-launcher
May 19, 2025
Merged

[KOB-49917] Allow steps on launcher#54
d4rkwinz merged 1 commit into
masterfrom
KOB-49917-launcher

Conversation

@chuong777
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 16, 2025 08:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds idle delays and launcher support by introducing rotation and location helpers, updating visibility logic, and extending script generators.

  • Define ORIENTATIONS constant for screen rotation
  • Introduce Config.IDLE_DELAY_IN_MS and apply sleeps after driver actions
  • Add rotateScreen and setLocation in all TestBase implementations and update service generators

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/templates/nodejs/src/test/helper/constants.js Add ORIENTATIONS constant for rotation
src/templates/nodejs/src/test/helper/base.js Apply idle delays, add rotate/setLocation methods, adjust visibility
src/templates/nodejs/src/test/helper/app.js Import ORIENTATIONS for new rotation functionality
src/templates/nodejs/src/test/config.js Add IDLE_DELAY_IN_MS configuration
src/templates/java/TestBase.java Mirror idle delays, rotation/location APIs, adjust visibility logic
src/templates/java/Config.java Add IDLE_DELAY_IN_MS constant
src/templates/csharp/TestBase.cs Mirror idle delays, rotation/location APIs, adjust visibility logic
src/templates/csharp/Config.cs Add IdleDelayInMs constant
src/services/nodejs.js Generate calls to rotateScreen and setLocation
src/services/java.js Generate calls to new helper methods
src/services/csharp.js Generate calls to new helper methods
Comments suppressed due to low confidence (4)

src/templates/nodejs/src/test/helper/base.js:932

  • The new rotateScreen (and setLocation) helpers lack corresponding unit or integration tests—consider adding coverage for these methods.
async rotateScreen(orientation) {

src/templates/nodejs/src/test/helper/base.js:423

  • Dropped the original element visibility check (elementIdDisplayed). This may mark hidden elements as visible—reintroduce combining isElementVisible with the rect checks.
visible = rect.x >= 0 && rect.y >= 0 && rect.width > 0 && rect.height > 0

src/templates/java/TestBase.java:412

  • Removed the element.isDisplayed() check, which could cause invisible elements to be treated as visible. Consider restoring it alongside the rect validation.
visible = rect.x >= 0 && rect.y >= 0 && rect.width > 0 && rect.height > 0;

src/templates/csharp/TestBase.cs:484

  • The original element.Displayed check was removed—this can misreport visibility. Reapply it in combination with the rectangle bounds checks.
visible = rect.X >=0 && rect.Y >= 0 && rect.Width > 0 && rect.Height > 0;

Comment thread src/templates/nodejs/src/test/helper/base.js
Comment thread src/templates/nodejs/src/test/helper/base.js
@d4rkwinz d4rkwinz merged commit 8aa3b55 into master May 19, 2025
2 checks passed
@d4rkwinz d4rkwinz deleted the KOB-49917-launcher branch May 19, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants