fix(wingbits): move photo to bottom, taller popup, fix Sched/Est labels#1959
Open
fix(wingbits): move photo to bottom, taller popup, fix Sched/Est labels#1959
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
Three UX issues with the Wingbits live data section in the flight popup:
Photo at top hid route/times behind scroll — The aircraft photo rendered first, pushing LHR→MLE route and scheduled/estimated times off screen. Users had to scroll to see the most useful info. Photo moved to the bottom of the section so route, times, and stats are immediately visible.
Popup too short — Desktop popup was capped at
380pxmax-height, not enough to show photo + route + times without scrolling. Increased tomin(560px, 80vh)(desktop) and75vh(mobile responsive breakpoint). The sheet variant on mobile already usesmin(72vh, ...).Sched/Estrow labels showed raw i18n keys —t('popups.flight.scheduled')andt('popups.flight.estimated')were not present insrc/locales/en.json, so i18next returned the key string verbatim (popups.flight.scheduled). The|| 'Sched'fallback never fired because the key string is truthy. Added both keys to the en locale.Changes
src/components/MapPopup.ts: extract photo intophotoHtmlvariable, append it after route/times/statssrc/styles/main.css:max-height: 380px→min(560px, 80vh)(desktop),60vh→75vh(mobile)src/locales/en.json: addpopups.flight.scheduled: "Sched"andpopups.flight.estimated: "Est"Test plan