Skip to content

fix(wingbits): move photo to bottom, taller popup, fix Sched/Est labels#1959

Open
koala73 wants to merge 1 commit intomainfrom
fix/wingbits-popup-layout
Open

fix(wingbits): move photo to bottom, taller popup, fix Sched/Est labels#1959
koala73 wants to merge 1 commit intomainfrom
fix/wingbits-popup-layout

Conversation

@koala73
Copy link
Owner

@koala73 koala73 commented Mar 20, 2026

Why this PR?

Three UX issues with the Wingbits live data section in the flight popup:

  1. Photo at top hid route/times behind scroll — The aircraft photo rendered first, pushing LHR→MLE route and scheduled/estimated times off screen. Users had to scroll to see the most useful info. Photo moved to the bottom of the section so route, times, and stats are immediately visible.

  2. Popup too short — Desktop popup was capped at 380px max-height, not enough to show photo + route + times without scrolling. Increased to min(560px, 80vh) (desktop) and 75vh (mobile responsive breakpoint). The sheet variant on mobile already uses min(72vh, ...).

  3. Sched/Est row labels showed raw i18n keyst('popups.flight.scheduled') and t('popups.flight.estimated') were not present in src/locales/en.json, so i18next returned the key string verbatim (popups.flight.scheduled). The || 'Sched' fallback never fired because the key string is truthy. Added both keys to the en locale.

Changes

  • src/components/MapPopup.ts: extract photo into photoHtml variable, append it after route/times/stats
  • src/styles/main.css: max-height: 380pxmin(560px, 80vh) (desktop), 60vh75vh (mobile)
  • src/locales/en.json: add popups.flight.scheduled: "Sched" and popups.flight.estimated: "Est"

Test plan

  • Open Wingbits-enriched flight popup (e.g. BAW61 / 406a34)
  • Route (LHR → MLE) and scheduled times visible without scrolling
  • Photo visible at the bottom of the Live Data section
  • "Sched" and "Est" labels show correctly (not raw key strings)
  • Popup fits full content on desktop without feeling too large

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
worldmonitor Ignored Ignored Mar 20, 2026 9:25pm

Request Review

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant