fix(ui): hide entire map-section during panel fullscreen (#829, #859)#1313
Open
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Open
fix(ui): hide entire map-section during panel fullscreen (#829, #859)#1313NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Conversation
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@NewCoder3294 would you please fix the images in the Post , they are broken. |
Collaborator
Author
|
oops, will work on that. I know you are busy, but can you respond to my x dm? If you can not find it, my X account is attached to my GitHub profile. |
Collaborator
Author
|
Owner
|
Cool , was referring to this (check top of this page) 
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…koala73#859) Previous attempts (5 PRs) hid individual overlay elements one by one (.layer-toggles, .map-legend, .deckgl-layer-toggles, etc.) but new elements kept slipping through. Replace the fragile element-by-element allowlist with a single rule that hides the entire .map-section container, which covers the WebGL canvas, all overlays, controls, legend, layer toggles, bottom grid, and resize handle. Key changes: - Add visibility: visible !important to .live-news-fullscreen so it stays visible even when an ancestor is hidden - Hide .map-section:not(.live-news-fullscreen) to cover all map children while allowing map-section itself to go fullscreen - Add pointer-events: none to hidden sibling panels - Consolidate 3 redundant rule blocks into clean, documented rules Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
koala73
force-pushed
the
fix/fullscreen-overlay-and-settings-persistence
branch
from
4de8949 to
3b49ebb
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.map-sectionhide rule that comprehensively covers the WebGL canvas, all overlays, controls, legend, layer toggles, bottom grid, and resize handlevisibility: visible !importantto.live-news-fullscreenso fullscreen panels stay visible even when ancestors are hidden:not(.live-news-fullscreen)guard to prevent map section from hiding itself when it is the fullscreen elementContext
Five previous PRs (#689, #708, #857, #887, #934) attempted to fix these issues by hiding individual overlay elements (
.layer-toggles,.map-legend,.deckgl-layer-toggles,.map-controls, etc.), but new elements kept slipping through. This fix takes a different approach — hiding the entire.map-sectioncontainer instead of chasing individual children.Scenarios verified with screenshots
Live News fullscreen
Live Webcams fullscreen
Map fullscreen
Test plan
Closes #829
Closes #859
🤖 Generated with Claude Code