Adding a timeout to fix infinite looping on corrupt bdb database files. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #37
Description of changes:
Adds a
contextobject to the ListPackages() and related methods (e.g.Read()so that a timeout can be implemented for the underlying bdb database parsing. Therpmdbinterface is backwards-compatible, and the context timeout is not implemented for other database file types as there the relevant issue does not apply.Note: the
Read()interface change is not backwards-compatible, but it seems like an internal method for underlying database parsing.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, as specified by the MIT License.