Open
Conversation
… own Torrent model
Contributor
|
One small nit/question: why have the setters on the TorrentInterface? Surely to fulfill the contract for a 'torrent' you need to ask for the torrents details, and or construct it in an implementation-specific manner, but not expose setters? |
Author
|
Hm… I guess it is to make the interface fully interoperable with the rest of the code. I mean, if the But sure, for now that is not obviously needed. Do you see any drawback to keep setters in the interface? What would you suggest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to be able to use my own Torrent model with the Transmission lib.
This PR adds a
TorrentInterfaceand change the Transmission.php dependency from theTorrentimplementation to this new interface.