Open
Conversation
shtrom
reviewed
Oct 17, 2023
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
No particular issue. A few nits, but should be fine otherwise.
| @@ -0,0 +1,3 @@ | |||
| [submodule ".project_extension"] | |||
| path = .project_extension | |||
| url = git@github.com:Learnosity/tools-common-extensions.git | |||
There was a problem hiding this comment.
When this is moved, you should use a relative path https://github.com/Learnosity/api-aiproxy/blob/main/.gitmodules#L3
| # If you are building your code for production | ||
| # RUN npm ci --omit=dev | ||
| # Bundle app source | ||
| COPY ../../.. . |
There was a problem hiding this comment.
This is not needed for LDE, as the docker-compose file mounts the current dev code. But it also doesn't hurt.
There was a problem hiding this comment.
I'm surprised by the ../../.. bit, as the build context in the docker-compose file is . from the root https://github.com/klauste/mockai/pull/1/files#diff-05e39158df47d1d49074fef2681a1b22afa5387a51e830d708613c64b63ad0ceR18-R20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LRN-41735