add option to use non-default api password for basic auth#93
Open
Weranders wants to merge 1 commit intoklacol:mainfrom
Open
add option to use non-default api password for basic auth#93Weranders wants to merge 1 commit intoklacol:mainfrom
Weranders wants to merge 1 commit intoklacol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Thanks for the great work beforehand.
I had trouble initializing your corresponding clage_homeserver integration for home assistant (https://github.com/klacol/homeassistant-clage_homeserver), so I did some digging and found out that the python lib always uses the default credentials for the API.
Being a security nerd, I never use default passwords - so I added the possibility to add the app password together with the other configuration options.
Tested locally - it fixed the issue for me. This is a breaking change, but this project doesn't seem to be used much "out in the wild" apart from home assistant. I'm happy to discuss approaches other than breaking the existing init signature.
Best,
Jan