-
-
Notifications
You must be signed in to change notification settings - Fork 91
Adds demo page and support for prefers-reduced-motion #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@therunnas has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 38 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (24)
WalkthroughAdds a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
demo.html (3)
2-2: Language mismatch (lang="en"but content is PT-BR)The document language is declared as English, yet most visible copy is Portuguese. Set
lang="pt-BR"(or translate the copy) to keep screen-readers and SEO happy.
26-28: Avoid<br>for layout inside formsHard line-breaks couple markup and layout. Replace them with semantic HTML and CSS margin rules, e.g.:
-<label>Nome: <input type="text" /></label><br><br> -<label>Email: <input type="email" /></label><br><br> +<p><label>Nome: <input type="text"></label></p> +<p><label>Email: <input type="email"></label></p>Keep presentation in CSS.
28-28: Add explicittypeattribute to buttonsBrowsers default
<button>inside a form totype="submit", but the same element outside a form defaults totype="submit"as well in some UAs. Be explicit to avoid surprises:-<button>Enviar</button> +<button type="submit">Enviar</button>Likewise, line 34 should probably be
type="button".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
demo.html(1 hunks)src/components/global.scss(1 hunks)
🔇 Additional comments (1)
demo.html (1)
7-7: Verify stylesheet path
href="reseter.css"is relative todemo.html; if the built asset lives elsewhere (e.g.dist/reseter.css) this link will 404 when the file is opened directly. Double-check/adjust the path.
kkrishguptaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, since the rest of the project is in english, could you please translate it to english? also can demo.html be split into a second PR since its a unrelated change. Lastly please check the comment left by coderrabbitai.
Thank you.
|
Closed in favour of #356 |
Summary by CodeRabbit
Documentation
Style