Skip to content

Conversation

@therunnas
Copy link

@therunnas therunnas commented Aug 1, 2025

  • Added the demo.html file with visual elements (lists, buttons, forms) to demonstrate the reset.
  • Includes support for the prefer reduced motion media query in global.scss, improving accessibility for users with animation sensitivity.

Summary by CodeRabbit

  • Documentation

    • Added a demo page that visually showcases the CSS reset’s impact on common elements—lists, forms, buttons, and typography—for quick visual verification.
  • Style

    • Added reduced-motion support: animations and transitions are disabled for users who prefer reduced motion, and smooth scrolling is turned off to respect that preference and improve accessibility.

@coderabbitai
Copy link

coderabbitai bot commented Aug 1, 2025

Warning

Rate limit exceeded

@therunnas has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 55587a0 and 736111a.

⛔ Files ignored due to path filters (4)
  • .github/assets/codepen.png is excluded by !**/*.png
  • .github/assets/css_reset.png is excluded by !**/*.png
  • .github/assets/gardevoir.png is excluded by !**/*.png
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (24)
  • .browserslistrc (0 hunks)
  • .bundlewatch.config.js (0 hunks)
  • .editorconfig (0 hunks)
  • .github/ISSUE_TEMPLATE/bug_report.yml (0 hunks)
  • .github/ISSUE_TEMPLATE/documentation.yml (0 hunks)
  • .github/ISSUE_TEMPLATE/feature_request.yml (0 hunks)
  • .github/ISSUE_TEMPLATE/other.yml (0 hunks)
  • .github/PULL_REQUEST_TEMPLATE.md (0 hunks)
  • .github/workflows/release.yml (0 hunks)
  • .gitignore (0 hunks)
  • .releaserc.js (0 hunks)
  • CHANGELOG.md (0 hunks)
  • CODE_OF_CONDUCT.md (0 hunks)
  • CONTRIBUTING.md (0 hunks)
  • LICENSE (0 hunks)
  • README.md (0 hunks)
  • package.json (0 hunks)
  • renovate.json (0 hunks)
  • src/components/forms.scss (0 hunks)
  • src/components/global.scss (0 hunks)
  • src/components/other.scss (0 hunks)
  • src/components/text.scss (0 hunks)
  • src/index.scss (0 hunks)
  • src/mini.scss (0 hunks)

Walkthrough

Adds a new demo.html demonstration page for reseter.css and a @media (prefers-reduced-motion: reduce) rule in src/components/global.scss disabling animations, transitions, and smooth scrolling for reduced-motion preferences.

Changes

Cohort / File(s) Change Summary
Demo HTML Page
demo.html
Added a standalone HTML demo illustrating reseter.css effects on headings, lists, forms, buttons, and text.
Accessibility: Reduced Motion CSS
src/components/global.scss
Added @media (prefers-reduced-motion: reduce) to disable animations/transitions and set scroll-behavior: auto.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I hop through markup, tidy and bright,
A demo to show each element’s light.
Soft-motion rules for calm, gentle days,
I nibble away at flashing displays.
🐇🌿

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Adds demo page and support for prefers-reduced-motion" concisely and accurately summarizes the PR's primary changes — adding demo.html and introducing a prefers-reduced-motion media query in global.scss — matching the provided file summaries and objectives. It is a single, specific sentence without extraneous detail or vague language, so a reviewer scanning history will understand the main intent. The title therefore meets the repository's clarity and brevity expectations.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
demo.html (3)

2-2: Language mismatch (lang="en" but content is PT-BR)

The document language is declared as English, yet most visible copy is Portuguese. Set lang="pt-BR" (or translate the copy) to keep screen-readers and SEO happy.


26-28: Avoid <br> for layout inside forms

Hard line-breaks couple markup and layout. Replace them with semantic HTML and CSS margin rules, e.g.:

-<label>Nome: <input type="text" /></label><br><br>
-<label>Email: <input type="email" /></label><br><br>
+<p><label>Nome: <input type="text"></label></p>
+<p><label>Email: <input type="email"></label></p>

Keep presentation in CSS.


28-28: Add explicit type attribute to buttons

Browsers default <button> inside a form to type="submit", but the same element outside a form defaults to type="submit" as well in some UAs. Be explicit to avoid surprises:

-<button>Enviar</button>
+<button type="submit">Enviar</button>

Likewise, line 34 should probably be type="button".

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e89f83b and b4627af.

📒 Files selected for processing (2)
  • demo.html (1 hunks)
  • src/components/global.scss (1 hunks)
🔇 Additional comments (1)
demo.html (1)

7-7: Verify stylesheet path

href="reseter.css" is relative to demo.html; if the built asset lives elsewhere (e.g. dist/reseter.css) this link will 404 when the file is opened directly. Double-check/adjust the path.

@therunnas therunnas changed the title Adiciona demo.html e suporte a prefers-reduced-motion no global.scss Adds demo page and support for prefers-reduced-motion Aug 1, 2025
Copy link
Owner

@kkrishguptaa kkrishguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, since the rest of the project is in english, could you please translate it to english? also can demo.html be split into a second PR since its a unrelated change. Lastly please check the comment left by coderrabbitai.

Thank you.

@kkrishguptaa
Copy link
Owner

Closed in favour of #356

@therunnas therunnas deleted the add-demo-and-accessibility branch September 23, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants