-
-
Notifications
You must be signed in to change notification settings - Fork 44
Migrate project to Bootstrap 4 #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate project to Bootstrap 4 #799
Conversation
…th Font Awesome 5 Major changes: - Upgraded Bootstrap 3.3.7 to Bootstrap 4.6.2 for modern CSS framework - Replaced Glyphicons with Font Awesome 5.15.4 for better Tailwind compatibility - Removed jQuery dependency (was unused, Bootstrap JS was already disabled) - Updated all HTML components: panels → cards, glyphicons → Font Awesome icons - Migrated app.css overrides to use Bootstrap 4 class names - Updated rollup.config.js to copy Bootstrap 4 and Font Awesome assets to dist Technical details: - .panel/.panel-heading/.panel-body → .card/.card-header/.card-body - .panel-info/warning/danger → .card.border-info/warning/danger - All 15 unique Glyphicons replaced with Font Awesome equivalents - Updated documentation in About section to reflect new libraries - Maintained IE11 and Edge 18 compatibility (Bootstrap 4.6.2 supports IE10+) This migration prepares the codebase for future Tailwind CSS adoption by: 1. Using framework-agnostic Font Awesome icons 2. Modernizing component structure (cards vs panels) 3. Eliminating jQuery dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR successfully migrates the project from Bootstrap 3.3.7 to Bootstrap 4.6.2, replacing Glyphicons with Font Awesome 5.15.4 icons and removing the jQuery dependency. The migration modernizes the CSS framework while maintaining IE11 and Edge 18 compatibility.
Key changes include:
- Updated all Bootstrap 3 components to Bootstrap 4 equivalents (panels → cards, glyphicons → Font Awesome icons)
- Migrated CSS class names and added Bootstrap 4-specific overrides in app.css
- Updated build configuration to copy Bootstrap 4 and Font Awesome assets to the dist folder
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| www/index.html | Migrated all HTML components from Bootstrap 3 to Bootstrap 4 classes (panels → cards, col-xs-* → col-*, glyphicons → Font Awesome icons, input-group-addon → input-group-text) |
| www/css/app.css | Added extensive Bootstrap 4 overrides, replaced panel/glyphicon CSS selectors with card/Font Awesome equivalents, added custom .card-heading styles for collapsible configuration sections |
| www/js/app.js | Updated JavaScript references to use Bootstrap 4 class names and Font Awesome icon classes instead of glyphicons |
| www/js/lib/uiUtil.js | Updated DOM queries and class name checks to use .card-heading/.card-body instead of .panel-heading/.panel-body, changed collapse indicator characters |
| rollup.config.js | Updated asset copying to include Bootstrap 4 and Font Awesome files from node_modules, removed jQuery references |
| package.json | Added Bootstrap 4.6.2 and Font Awesome 5.15.4 as dev dependencies, removed jQuery dependency |
| package-lock.json | Updated dependency tree to reflect Bootstrap 4 and Font Awesome additions, jQuery marked as peer dependency only |
| scripts/patch_gitignore.sh | Updated gitignore patching to allow Bootstrap files instead of jQuery |
| .gitignore | Added /dist/node_modules entry to ignore copied node_modules in dist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 12 out of 19 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Some issues still to fix:
|
Fixes #803.
Major changes:
Technical details:
This migration prepares the codebase for future Tailwind CSS adoption by: