Skip to content

Conversation

@kelson42
Copy link
Collaborator

Should allow us to finally merge #1387

@kelson42 kelson42 added this to the 2.5.0 milestone Oct 31, 2025
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the language self-name isn't used anywhere, we may need it in the future. Dropping this piece of information just because someone entered it incorrectly in one of the translations isn't justified.

@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 31, 2025

The reason why IMO it shoudl be dropped:

  • It is not used
  • It is not the right place to do that (here we talk about translations, not creating a list of language)
  • I believe we should not have such a list of language here, as it should be in a central place (so libkiwix or maybe even in libicu... but this is not the discussion here).

To conclude, we could need language names for the UI (not used here as we don't have such setting in Kiwix Desktop) or for the library (it comes from libkiwix).

So I really not see why we shoukd keep that.

@veloman-yunkan
Copy link
Collaborator

  • It is not the right place to do that (here we talk about translations, not creating a list of language)

We are not creating a list of languages. We just need to know the name of the language of the translation, and the translation file is the best place for it. Translators are the best source of that information. kiwix-desktop and libkiwix are unrelated projects in that regards. If some user of kiwix-desktop decides to add a new language, it is easier if they do it entirely in one place instead of providing translations via translatewiki and filing a request to register the language name in libkiwix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants