fix: resolve empty line and navigation issue in search bar (#1273) #1366
Conversation
|
I have refactored the code to ensure it passes all the checks. @kelson42 Kindly review. |
kelson42
force-pushed
the
fix/suggestion-box-1273
branch
from
c3fdd6a to
99d5aa1
Compare
kelson42
force-pushed
the
fix/suggestion-box-1273
branch
from
99d5aa1 to
675fd0a
Compare
kelson42
force-pushed
the
fix/suggestion-box-1273
branch
from
675fd0a to
d6e9433
Compare
|
@Jinash-Rouniyar Thank younvery much for your PR. I will ahve a look to it tomorrow |
kelson42
force-pushed
the
fix/suggestion-box-1273
branch
from
f83ffeb to
6795448
Compare
|
@Jinash-Rouniyar Thank you so much for your patience... but I have a serious problem : I don't achieve to reproduce the problem with either Qt5 or Qt6 with |
|
@kelson42 Since the issue is not reproducible on your end and I haven't received a review from @veloman-yunkan , would you prefer that I close this PR? I don’t want to keep it open unnecessarily, so please let me know what you’d recommend. |
|
@Jinash-Rouniyar Please excuse me for the lack of feedback. @veloman-yunkan can you please have a look to this PR and let us know if this brings a few improvements we should keep? |
|
@veloman-yunkan Could you please have a look to this PR? |
kelson42
force-pushed
the
fix/suggestion-box-1273
branch
from
6795448 to
2a6b4c0
Compare
2 participants
Fixes #1273
I have implemented custom event filtering that maintains proper selection state while scrolling to prevent unwanted scroll behavior at the top and bottom of lists while still maintaining the existing scroll behavior. This implementation also helped resolve the unwanted empty line at the bottom of the search bar. Kindly review.