-
Notifications
You must be signed in to change notification settings - Fork 584
Upgrade from deprecated macos-13 to macos-15-intel in CI #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Install OS specific dependencies | ||
- name: Install Linux dependencies | ||
if: matrix.os == 'ubuntu-latest' | ||
if: runner.os == 'Linux' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes positive. The detecting the operating system link in the commit message.
.github/workflows/ios.yml
Outdated
# macos-13 runs on Intel | ||
runs_on: [macos-latest, macos-13] | ||
# macos-15-intel runs on Intel | ||
runs_on: [macos-latest, macos-15-intel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using explicit naming for both so we know what we're talking about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names of the GitHub Actions runner images are specified in the left column of the table of the commit message. We cannot change the names of those runner images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, why not macos-15
rather than macos-latest
so we're explicit about what version we're trying to run.
also any plan on running macos-14
?
Also I like that the label macos-15-intel
is already explicit about the architecture, that way we can remove the comment above it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using macos-latest
is the best way to continue migrating as users do. We want CI to warn us of breakage before users do. macOS users tend to upgrade faster than users of other operating systems, so the gradual rolling upgrade that GitHub does is quite useful. We have been testing on macos-14
until this month, when macos-latest
was upgraded to 15. While macos-26
is available to us, it is very recent.
If you would like, we could do: runs_on: [macos-14, macos-latest, macos-26, macos-15-intel]
; however, I would avoid pinning all versions because Actions configs are often ignored until they break.
9fa79c2
to
df983e0
Compare
Upgrade from deprecated `macos-13` GitHub Actions runner to `macos-15-intel`. The currently available GitHub Actions macOS runners are: | macOS Version | runner.arch | |---------------|-------------| | macos-13 | X64 | | macos-14 | ARM64 | | macos-15 | ARM64 | | macos-15-intel | X64 | | macos-26 | ARM64 | | macos-latest | ARM64 | * Let's prepare for actions/runner-images#13046 * Like: kivy/kivy#9162 Should a set of test runs be made on `macos-26`?
Upgrade from deprecated
macos-13
GitHub Actions runner tomacos-15-intel
.The currently available GitHub Actions macOS runners are:
Should a set of test runs be made on
macos-26
?Also,
if: runner.os == 'Linux'
-- Detecting the operating system