Skip to content

Improve log message on failed requirements installation for plugin due to missing expected file#313

Open
GGoetzelmann wants to merge 1 commit intodevelopmentfrom
plugins-minor-log-improvement
Open

Improve log message on failed requirements installation for plugin due to missing expected file#313
GGoetzelmann wants to merge 1 commit intodevelopmentfrom
plugins-minor-log-improvement

Conversation

@GGoetzelmann
Copy link
Copy Markdown

  • specify expected file name for requirements file in log message
    • reasoning: it wouldn't be a default for a python project to have file with this exact name, so the expected file name should be documented / explained. This change provides at least basic explanation on failure.
  • bump log level to warning
    • reasoning: not having the need to install any requirements, and therefore lacking the file completely, is likely a very rare case for plugins, so it should not throw an error, but a warning is warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant