Improve log message on failed requirements installation for plugin due to missing expected file#313
Open
GGoetzelmann wants to merge 1 commit intodevelopmentfrom
Open
Improve log message on failed requirements installation for plugin due to missing expected file#313GGoetzelmann wants to merge 1 commit intodevelopmentfrom
GGoetzelmann wants to merge 1 commit intodevelopmentfrom
Conversation
GGoetzelmann
commented
Apr 17, 2026
- specify expected file name for requirements file in log message
- reasoning: it wouldn't be a default for a python project to have file with this exact name, so the expected file name should be documented / explained. This change provides at least basic explanation on failure.
- bump log level to warning
- reasoning: not having the need to install any requirements, and therefore lacking the file completely, is likely a very rare case for plugins, so it should not throw an error, but a warning is warranted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.