Skip to content

feat: indicate uniqueness of data source picker entry#186

Merged
Pfeil merged 3 commits intomainfrom
feature-185
Apr 21, 2026
Merged

feat: indicate uniqueness of data source picker entry#186
Pfeil merged 3 commits intomainfrom
feature-185

Conversation

@craquet
Copy link
Copy Markdown
Member

@craquet craquet commented Mar 5, 2026

grafik

Alternatives to the star icon could be:

Merging to main as development is very out of date 😄

@craquet craquet requested a review from Pfeil March 5, 2026 14:41
@craquet craquet linked an issue Mar 5, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@Pfeil Pfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Just some small stuff:

tooltip appearence delay

Image

This tooltip takes a while to hover on until it appears. This is consistent with the other tooltips, but not with the one of the availability bar on the left, where it appears much faster. I think as the icon is not 100% intuitive, a faster tooltip could be appropriate here. What do you think?

icon

  • sparkles are currently associated with AI, so I would not choose something too similar.
  • snowflake doesn't trigger the association for me
  • DNA is cool, but can be confusing if the data is actually really related to DNA somehow
  • I like the fingerprint.
  • I somehow have issues with the star. It tells me "favorite", which also does not perfectly match. Especially as it looks like I should be able to click it (not filled).

So I would either prefer the fingerprint or try to make the star solid, if possible. But I also want to propose another icon:

What do you think?

tooltip text

Somehow the text seems vague to me. Maybe "These values are unique (different in each provided file)"?

@craquet
Copy link
Copy Markdown
Member Author

craquet commented Mar 6, 2026

Thanks for the input! I tried out your suggestions as well as another idea, and I'm still not sure which one is the most suitable. I think none of them are as self-explanatory as I would want them to be... But turns out, there is no perfect symbol for saying "this value is unique in all provided example files" 😄

With Circle Icon

Problem: The availability scale and the icon look kind of the same. I find this a bit confusing
grafik

With Fingerprint Icon

Problem: None?
grafik

Integrated into Availability Scale

Idea: Only add the dot in the middle if all values are unique.

Problem: we have no symbol for quickly checking for 100% availability

grafik

Comment thread components/data-source-picker/Entry.tsx Outdated
Comment on lines +109 to +110
The values of this entry are unique in
each provided file
Copy link
Copy Markdown
Member

@Pfeil Pfeil Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence can be misinterpreted as "unique within each file". Should rather be "unique for each file" or so? Actually I am not sure if it is really better. But I find it similarly unclear to the original sentence. Maybe it is just me? How about "The values of this entry are different in each provided file"?

@Pfeil
Copy link
Copy Markdown
Member

Pfeil commented Mar 6, 2026

Good points. I'd prefer the fingerprint, I guess. Tbh, I did not find any, but I thought an "id" with a circle around it might fit. There is an "id card" icon but I think it would be confusing and associated with persons. Am I overbiased with the star being not filled looking like a button? Maybe it would also look like a fav button if it is filled, though.

I am in principle also not against something more abstract. At least we would avoid misinterpretation. Something like https://lucide.dev/icons/triangle or so. Not sure. Anyway, how about we just choose something and try to get some overall feedback before the workshop from DEM.

Let's just keep the fingerprint for now. What do you think about my remark to the text?

@craquet
Copy link
Copy Markdown
Member Author

craquet commented Mar 10, 2026

@Pfeil changed the text to also include a note that the value might be used as an identifier. As that is the actual intent behind the icon, it might make sense to tell the user 😄

I also increased the tooltip delay back to 700ms. My thinking is that this is a tooltip that will be used when a user doesn't understand the fingerprint icon yet, but will not need in the future (hopefully). This is different to the availability scale, which the user might want to look into more frequently to get more details than is visible through the icon. But for the fingerprint icon the tooltip content never changes, and it is a bit clunky to always throw the popup at the user whenever their mouse crosses over the fingerprint icon

@craquet craquet requested a review from Pfeil April 2, 2026 08:20
@Pfeil Pfeil merged commit 347d634 into main Apr 21, 2026
2 checks passed
@Pfeil Pfeil deleted the feature-185 branch April 21, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picker could make statement about uniqueness

2 participants