Skip to content

Limit logfile size#295

Open
FelixFrizzy wants to merge 2 commits intodevelopmentfrom
limit-logsize
Open

Limit logfile size#295
FelixFrizzy wants to merge 2 commits intodevelopmentfrom
limit-logsize

Conversation

@FelixFrizzy
Copy link
Copy Markdown
Collaborator

@FelixFrizzy FelixFrizzy commented Mar 4, 2026

Summary by CodeRabbit

  • Chores
    • Updated logging across multiple services to enforce local log rotation with limits on file size and retained files. This standardizes log handling, reduces unbounded disk growth, and improves operational stability and troubleshooting consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 4, 2026

Walkthrough

Logging configuration blocks were added to eight services in docker-compose.yml, each setting logging.driver: "local" with options max-size: "20m" and max-file: "5" to enforce local log rotation and size limits.

Changes

Cohort / File(s) Summary
Logging Configuration
docker-compose.yml
Added logging blocks (driver: "local", options: max-size: "20m", max-file: "5") for services: proxy, postgres, change-vol-ownership, web, fuseki-dev, fuseki-live, skosmos-dev, skosmos-live.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Limit logfile size' directly and clearly describes the main change: adding logging configuration to enforce log rotation and size limits across multiple Docker services.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch limit-logsize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add skosmos v3 to branch to enable tests
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.31%. Comparing base (bfa3124) to head (5743c9b).
⚠️ Report is 1 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #295   +/-   ##
============================================
  Coverage        92.31%   92.31%           
============================================
  Files               50       50           
  Lines             1848     1848           
============================================
  Hits              1706     1706           
  Misses             142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docker-compose.yml (1)

22-26: Optional maintainability refactor: centralize the repeated logging config.

You can reduce duplication by defining shared logging defaults once and reusing them per service.

♻️ Example refactor with YAML anchor
+x-logging-defaults: &logging_defaults
+  driver: "local"
+  options:
+    max-size: "20m"
+    max-file: "5"
+
 services:
   proxy:
@@
-    logging:
-      driver: "local"
-      options:
-        max-size: "20m"
-        max-file: "5"
+    logging: *logging_defaults
@@
   postgres:
@@
-    logging:
-      driver: "local"
-      options:
-        max-size: "20m"
-        max-file: "5"
+    logging: *logging_defaults

Also applies to: 44-48, 77-81, 118-122, 149-153, 180-184, 220-224, 260-264

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docker-compose.yml` around lines 22 - 26, Define a shared logging anchor and
reference it from each service instead of repeating the logging block: add a
top-level YAML key like x-logging-defaults with driver: "local" and options
max-size/max-file, then replace each service's logging block (the repeated
logging: driver/options entries shown in the diff) with a reference to that
anchor (use <<: *x-logging-defaults or logging: *x-logging-defaults depending on
style) so all services reuse the centralized settings and preserve the same
option keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@docker-compose.yml`:
- Around line 22-26: Define a shared logging anchor and reference it from each
service instead of repeating the logging block: add a top-level YAML key like
x-logging-defaults with driver: "local" and options max-size/max-file, then
replace each service's logging block (the repeated logging: driver/options
entries shown in the diff) with a reference to that anchor (use <<:
*x-logging-defaults or logging: *x-logging-defaults depending on style) so all
services reuse the centralized settings and preserve the same option keys.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: acae778e-ee78-4191-a954-205b944da061

📥 Commits

Reviewing files that changed from the base of the PR and between 686416e and 5743c9b.

📒 Files selected for processing (1)
  • docker-compose.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant